Feature: Update error pages to match modern TOP styling #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMulhern
added
the
Type: Enhancement
KevinMulhern
requested changes
Jun 25, 2023
There was a problem hiding this comment.
Thanks for all your work on this @Asartea, this is a huge improvement 🔥
I've left some feedback, mostly minor styling and wording changes. Happy to discuss any of it.
|
Should all be done @KevinMulhern |
|
I have no clue what is up with that failed test; given that I only made changes in |
|
All good @Asartea , it's nothing you've done, just a flaky test on CI - we've been getting them a lot lately 😓. Rerunning the CI job now, that should sort it out. |
KevinMulhern
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
💥 These look great, thank you for taking the time to do them @Asartea 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This PR
400.html422.htmland500.htmlto use a modified version of https://tailwindui.com/components/marketing/feedback/404-pages#component-ebef3404d06e7b5f42e85b7b2ca4a2a5, with theme colors taken from TOP's light themeIssue
Closes #3660
Pull Request Requirements
keyword: brief description of changeformat, using one of the following keywords:Feature- adds new or amends existing user-facing behaviorChore- changes that have no user-facing value, refactors, dependency bumps, etcFix- bug fixesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection